On Tue, March 27, 2018 22:24, Jaap Eldering wrote:
- removed time intervals
The code in calcContestTime looks fairly simple. The UI only affects the contest page. Did I miss anything?
Yes, there's very little interaction with the rest of the code. There's also a single extra column on the contests page and some code in lib/www/checkers.jury.php, but that's about it.
I would still wrap it inside a configuration setting (buried in etc/domserver-config.php) to not expose this abomination to people, unless you *explicitly* ask for it.
Agreed, and indeed wrap it inside a feature toggle so you can be sure the entire code is not executed/no queries are done to removed_intervals table/the contests interface is not cluttered when you're not using the feature.
Thijs